Skip to content

Feature/amp 151 get subscriptiom#7

Merged
coling01 merged 4 commits intomainfrom
feature/amp-151-get-subscriptiom
Dec 15, 2025
Merged

Feature/amp 151 get subscriptiom#7
coling01 merged 4 commits intomainfrom
feature/amp-151-get-subscriptiom

Conversation

@coling01
Copy link
Collaborator

@coling01 coling01 commented Dec 15, 2025 •
edited
Loading

  • Add get subscription endpoint by subscriptionId
  • Use fixed version 1.0.0
  • Make url with - not camel case as per spec i.e. /client-subscriptions
  • Remove import wildcards
  • Set updatedAt when entity created and make it non null
  • Move creationTimestamp and updatedTimestamp to mapper as the entity annotations are not reliable.
  • ( And we still have non null on the database of course )
  • Since we got 2 EventType in model and EventType in database, it can be painful when use them both in the same class i.e. Mapper so rename the db one to EntityEventType for better clarity
  • Make EventTypes 128 chars and notifyUrl 2048 chars in db table

@coling01
feature: amp-151 alpha sort event types in database
b00fb33 
* i.e. PCR, CUSTODIAL_RESULT is stored as CUSTODIAL_RESULT, PCR
@coling01
feature: amp-151 afixup import wildcards to 99 i.e. remove import .*
d8e1ce7
@coling01
feature: amp-151 add get endpoint and tidy ups
e9ac7f2 
* Add get by subscription id
* Pull in v1.0.0 api
* Default updatedAt with createdAt
* Make event_types 128 and notification endpoint 2048 in database table
@coling01 coling01 requested a review from a team as a code owner December 15, 2025 12:01
@coling01 coling01 merged commit ca2cef9 into main Dec 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samirgarg samirgarg samirgarg approved these changes

+1 more reviewer

@madhusudan-yasa madhusudan-yasa madhusudan-yasa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coling01 @samirgarg @madhusudan-yasa